Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

chore(gulp): except for check-deploy, gulp targets are for (ts|js) only #1915

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jul 18, 2016

For gulp, all the default for full-site build tasks (like check-deploy) and (ts|js) all other gulp targets.

@chalin
Copy link
Contributor Author

chalin commented Jul 18, 2016

@Foxandxss @wardbell : ready for review and merge.
@AlmeroSteyn: this should fix it.

cc @kwalrath

@chalin chalin force-pushed the chalin-dont-build-dart-api-without-dart-0718 branch from ef7d5b4 to dfcc8e0 Compare July 18, 2016 18:53
@Foxandxss
Copy link
Member

I like but I don't feel confortable having to put the --no-dart in all my commands. Shouldn't it be otherwise? --dart or something like that. There is only 2 people in here that does dart and we have a l10n project to localize this project and all of them needs to run this command too and none of them really care about dart.

@chalin
Copy link
Contributor Author

chalin commented Jul 18, 2016

I agree and debated that myself. I'm just worried that it is much easier to forget to put --dart when generating docs (and get no warning) than to forget --no-dart in other case (which will result in a friendly reminder being generated).

@naomiblack, @kwalrath : any opinion about this?

@wardbell
Copy link
Contributor

wardbell commented Jul 18, 2016

I thought the default was no-dart except for check-deploy.

gulp check-deploy (and the new variation that does a check w/o deploy) should do all languages. Otherwise, IMO, we should default to TS/JS and be explicit with --dart if we want it.

@chalin chalin changed the title chore(gulp): add --no-dart flag [WIP] chore(gulp): add --no-dart flag Jul 18, 2016
@chalin
Copy link
Contributor Author

chalin commented Jul 18, 2016

As per @wardbell's suggestion (made elsewhere) I'll make all the default for full-site build tasks (like check-deploy) and (ts|js) all other gulp targets.

@chalin chalin force-pushed the chalin-dont-build-dart-api-without-dart-0718 branch from dfcc8e0 to 0577021 Compare July 18, 2016 20:40
@chalin chalin force-pushed the chalin-dont-build-dart-api-without-dart-0718 branch from 0577021 to e9ab224 Compare July 18, 2016 20:45
@chalin chalin changed the title [WIP] chore(gulp): add --no-dart flag chore(gulp): except for check-deploy, gulp targets are for (ts|js) only Jul 18, 2016
@wardbell wardbell closed this in 83ba850 Jul 18, 2016
@chalin chalin deleted the chalin-dont-build-dart-api-without-dart-0718 branch July 18, 2016 22:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants