-
Notifications
You must be signed in to change notification settings - Fork 876
Conversation
Currently blocked by DefinitelyTyped/DefinitelyTyped#10082 |
|
c377fa2
to
168ecda
Compare
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
This needs update on other places were we pull typescript 1.x (like systemjs for plunkers and perhaps more places) |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
@Foxandxss updated plunker generator and a few other places in the files provided in #2227. Also searched for |
c5f13e6
to
06509a5
Compare
b153176
to
50ae0ef
Compare
[UMD typings](https://github.com/Microsoft/TypeScript/wiki/What's-new-in-TypeScript#support-for-umd-module-definitions) | ||
for a library, such as `@types/angular}, when used together with ES6 imports require the | ||
typed to be imported as well via `import * as angular from 'angular';`. | ||
We don't want to do this right now because we're still loading Angular 1 via a script tag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to do this right now because we're still loading Angular 1 via a script tag.
This concrete line. Even when it is true that we don't want to do this right now (we would need to teach system.js deeply here), it sounds weird. "Hey, I am lazy, don't want to do this, so please be happy with this note".
I would reword it somehow.
I agreed that the prose needed work. I updated and force pushed and now you can't see what the passage was before I rewrote it. Here is my new version:
If you two have no further objections AND my update survives Travis, I'll merge this in after lunch. |
Yes please. I need it to work on some other stuff tomorrow 👍 |
I agree with the edits, it looks better and addresses the problems that Jesus highlighted. Much better. |
This PR updates all examples to use
@types/*
. It also updates all chapters that mentiontypings
to talk about@types/*
instead.The
cli-quickstart
example was removed from tests though, since the version of TS it uses is stuck in 1.8.x right now and would fail due to lack of typings./cc @wardbell @Foxandxss