Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Link disambiguators #1852

Closed

Conversation

petebacondarwin
Copy link
Contributor

This is an alternative approach to some of #1846

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@petebacondarwin petebacondarwin force-pushed the link-disambiguators branch 2 times, most recently from 3bc96fb to b2f760b Compare July 8, 2016 15:10
@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added CLA: yes and removed CLA: no labels Jul 8, 2016
@chalin
Copy link
Contributor

chalin commented Jul 8, 2016

LGTM. Lovely clean design!
Supersedes #1846 (to be refactored and closed soon).

@wardbell
Copy link
Contributor

Merging on @chalin approval.

@wardbell wardbell closed this in 285ecf4 Jul 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants