This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(cheatsheet/dart): alert reader of possible inaccuracies #1814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kwalrath : as agreed, added a statement of caveat. |
|
Btw, I tried to regenerate the cheat sheet JSON file from Ng Dart's beta.17, but was unsuccessful. So I decided to opt for our caveat option. |
chalin
force-pushed
the
chalin-cheatsheet-warning-0702
branch
from
5058197 to
35d6d3d
Compare
chalin
force-pushed
the
chalin-cheatsheet-warning-0702
branch
from
35d6d3d to
df95190
Compare
|
@kwalrath I'm leaving this to you to merge. Not my department. Personally, I wouldn't do this. I'd fix the angular side. |
chalin
force-pushed
the
chalin-cheatsheet-warning-0702
branch
from
df95190 to
d33ae8b
Compare
| p.text-body.c10 This cheat sheet is provisional and may change. Angular 2 is currently in Release Candidate. | ||
| .alert.is-important | ||
| :marked | ||
| **Known issue**: some cheat sheet entries may be inaccurate since they |
There was a problem hiding this comment.
I usually include the : in the boldface and capitalize the character afterward (Some). Also, I think we should explain/promise less. Maybe:
Known issue: Some cheat sheet entries are currently inaccurate, reflecting TypeScript instead of Dart.
Until we can generate the cheat sheet properly, at least alert reader of possible inaccuracies.
chalin
force-pushed
the
chalin-cheatsheet-warning-0702
branch
from
d33ae8b to
adc82a1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until we can generate the cheat sheet properly, at least alert reader of possible inaccuracies.