This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(guide/lifecycle-hooks): follow-up to #1654 #1768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly Dart-side review, following angular#1654: - Updates to follow style guide - Enabled e2e tests - Fixes to ensure tests pass: in after_view_component.dart and after_content_component.dart - Changed test over comment field in template to be: *ngIf="comment.isNotEmpty" - Suites passed: public/docs/_examples/lifecycle-hooks/dart public/docs/_examples/lifecycle-hooks/ts
|
@kwalrath : ready for review. |
| @@ -20,7 +20,7 @@ class ChildComponent { | |||
| <div>-- projected content begins --</div> | |||
| <ng-content></ng-content> | |||
| <div>-- projected content ends --</div> | |||
| <p *ngIf="comment != null" class="comment">{{comment}}</p> | |||
| <p *ngIf="comment.isNotEmpty" class="comment">{{comment}}</p> | |||
There was a problem hiding this comment.
Should the . be ?.?
Actually, I guess ?. doesn't return a boolean. But should we do a null check?
|
LGTM aside from wondering whether a null comment will break this. |
|
By design, |
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dart-side updates following #1654:
after_content_component.dart
*ngIf="comment.isNotEmpty"