This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(toh-4/dart): copyedits #1637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
force-pushed
the
chalin-toh-4-dart-minor-edits-0609
branch
from
3293f94 to
2ec71e5
Compare
chalin
force-pushed
the
chalin-toh-4-dart-minor-edits-0609
branch
from
2ec71e5 to
8aedb3b
Compare
chalin
force-pushed
the
chalin-toh-4-dart-minor-edits-0609
branch
2 times, most recently
from
acd0418 to
6fb15c8
Compare
chalin
force-pushed
the
chalin-toh-4-dart-minor-edits-0609
branch
from
6fb15c8 to
09fbab2
Compare
| share that service with all components that need heroes. | ||
|
|
||
| ### Create the HeroService | ||
| Create a file in the `lib` folder called `hero_service.dart`. | ||
| .l-sub-section | ||
| :marked | ||
| We've adopted a convention in which we spell the name of a service in lowercase followed by `_service`. | ||
| If the service name were multi-word, we'd spell the base filename with lower underscore case (AKA "snake_case"). | ||
| If the service name were multi-word, we'd spell the base filename in lower underscore case (also called [snake_case](../guide/glossary.html#!#snake_case)). |
There was a problem hiding this comment.
Fix the snake_case link? (It just went to the top of the glossary page, for me.)
There was a problem hiding this comment.
The snake_case entry went in with the toh-3 changes. (edited)
|
LGTM, though we should fix that snake_case link. |
|
The |
|
I can't get the link to work in my build, but then building anything more than the devguide fails for me right now. I'll take your word that it works. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to #1628.