Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

docs(toh): update live example links #1602

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jun 4, 2016

Addresses #1596.

@chalin
Copy link
Contributor Author

chalin commented Jun 4, 2016

@kwalrath @Foxandxss @wardbell : minor update ready for review.

@Foxandxss
Copy link
Member

Foxandxss commented Jun 4, 2016

Sounds good, my only complain is... why Link2? What happened with link1?

@chalin
Copy link
Contributor Author

chalin commented Jun 4, 2016

:) ... Link2 actually generates 2 links in Dart.

@kwalrath
Copy link
Contributor

kwalrath commented Jun 6, 2016

I didn't try building it, but it LGTM. (More examples, yay!)

@chalin chalin force-pushed the chalin-update-links-to-examples-0603 branch from e2177fa to 3d58869 Compare June 7, 2016 10:41
@chalin
Copy link
Contributor Author

chalin commented Jun 7, 2016

Anything else to do before this is merged?

@kwalrath
Copy link
Contributor

kwalrath commented Jun 7, 2016

I'm going to merge this now.

@kwalrath kwalrath merged commit 7e52648 into angular:master Jun 7, 2016
@chalin chalin deleted the chalin-update-links-to-examples-0603 branch June 7, 2016 23:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants