Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

[WIP] fix(github link): replace relativePath from github link #1435

Closed
wants to merge 1 commit into from
Closed

[WIP] fix(github link): replace relativePath from github link #1435

wants to merge 1 commit into from

Conversation

ericjim
Copy link
Member

@ericjim ericjim commented May 19, 2016

WIP, do not merge; @petebacondarwin has suggested I amend https://github.com/angular/angular.io/pull/1224/files in some ways to fix this issue.

Changes

  • Construct the github url, from all api docs, appropriately.
  • Replace the part of the github link with pertains to the relative path of whomever is deploying the repo.

Preview

https://doc-bottom-link.firebaseapp.com/docs/ts/latest/api

Notes

CLOSES:
#1433

@naomiblack

@ericjim ericjim changed the title [WIP] fix(github link): replace relativePath from github link fix(github link): replace relativePath from github link May 19, 2016
@ericjim ericjim changed the title fix(github link): replace relativePath from github link [WIP] fix(github link): replace relativePath from github link May 19, 2016
@ericjim ericjim changed the title [WIP] fix(github link): replace relativePath from github link fix(github link): replace relativePath from github link May 19, 2016
@petebacondarwin
Copy link
Contributor

I don't think this is the right fix

@ericjim ericjim changed the title fix(github link): replace relativePath from github link [WIP] fix(github link): replace relativePath from github link May 19, 2016
petebacondarwin added a commit to petebacondarwin/angular.io that referenced this pull request May 19, 2016
@ericjim
Copy link
Member Author

ericjim commented May 19, 2016

Refer to #1440

@ericjim ericjim closed this May 19, 2016
wardbell pushed a commit that referenced this pull request May 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants