This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(dev guide): pipes - new dart prose; updated code; ts updates #1353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TS changes works for me. |
chalin
force-pushed
the
chalin-guide-pipes-0510
branch
5 times, most recently
from
3495d5d to
8edf918
Compare
(As confirmed by Matan Lurey.)
For `e2e-spec.js`: If the async test is executed too early it will fail (simply because the async message hasn’t been received yet).
- Follow new convention for naming constants.
chalin
force-pushed
the
chalin-guide-pipes-0510
branch
from
8edf918 to
298fc47
Compare
|
LGTM |
chalin
changed the title
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the Dart source is still at beta.15 (due to angular/angular#8258). The Dart example has been updated to have the same functionality as the TS example.