-
Notifications
You must be signed in to change notification settings - Fork 877
docs(cli-quickstart): add cli-quickstart chapter #1241
Conversation
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
02f53cd
to
466ad93
Compare
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
@wardbell I incorporated your changes and removed the Before this is merged, the CLI should be updated to new world and the example app re-generated. After that, docregions need to be re-added. |
29795d3
to
3983f6a
Compare
Still holding out for your approval |
b4166da
to
30db72c
Compare
30db72c
to
8e142c4
Compare
@wardbell PR is updated and ready. Description of PR also updated to reflect all changes and CLI chapter creation instructions. |
8e142c4
to
9d3c007
Compare
18da809
to
be0f2ed
Compare
The Angular-CLI build steps create symlinks which require administrator rights under Windows. | ||
|
||
:marked | ||
Now we're ready to write some code... or are we? We certainly could start writing code right now, but our tests would break. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we or are we? Sounds weird for me.
I reviewed it. All the steps works good on a new node environment, including the deploy thing. Leaving this aside, I thought this cookbook was a replacement for the actual 5 min quickstart and not just a quickstart on CLI. As a cookbook in how to get started on the CLI is good, but we still need a replica of the "5 min quickstart" but using the CLI. Same content, same things to add, but using the CLI. I find a bit confusing (or verbose) having to update both e2e and unit tests (which makes sense, but still verbose for the reader). Would be good if different changes could be made so both tests would need different set of changes. On the other hand, do we really need a whole set of instructions of how to set github? I would personally add a subsection on "Learn more in how to set a token here" Can't wait to have the CLI in more places, I love how simple it is. |
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
Won't close this because I still need to extract a CB from here and I don't want the branch to be removed by mistake. |
This PR includes both the Angular-CLI quickstart chapter and e2e test support for CLI applications.
It does not add the CLI-Quickstart to the sidebar menu though, nor live example via plunker.
To run e2e tests for CLI applications, you must have Angular-CLI installed globally and using the same version as specified in
public/docs/_examples/package.json
.When adding a new CLI-based chapter, create a project using
ng new chapter-name
and copy the contents of thechapter-name
dir ontopublic/docs/_examples/chapter-name/ts/
.Afterwards, add an
example-config.js
in the example project root, renamepackage.json
topackage.1.json
, removedeclare var module: { id: string };
fromsrc/typings.d.ts
(angular.io typings already includenode
).Finally, add
public/docs/_examples/chapter-name/e2e-spec.js
as usual.