Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

docs(ugprade): bring phonecat upgrade tutorial up to speed with modernized Angular 1.x PhoneCat #1106

Closed

Conversation

teropa
Copy link
Contributor

@teropa teropa commented Apr 18, 2016

WIP - Do not merge until Tero says "go"

Relates to angular/angular-phonecat#326
Relates to angular/angular.js#14416

@naomiblack
Copy link
Contributor

@teropa is this ready to merge?

@teropa
Copy link
Contributor Author

teropa commented Apr 20, 2016

@naomiblack Ideally we'd merge it around the same time with angular/angular.js#14416. @petebacondarwin what are your current plans for that?

@gkalpak
Copy link
Member

gkalpak commented Apr 20, 2016

It's better not to merge it yet. I'll ping you once angular/angular.js#14416 is merged (or ready to be merged).

@naomiblack
Copy link
Contributor

Thanks for the clarification!

@teropa teropa changed the title docs(ugprade): bring phonecat upgrade tutorial up to speed with modernized Angular 1.x PhoneCat WIP docs(ugprade): bring phonecat upgrade tutorial up to speed with modernized Angular 1.x PhoneCat Apr 27, 2016
@wardbell
Copy link
Contributor

wardbell commented May 1, 2016

@teropa - how does this relate to the new world version? My inclination is to stop dev here.

@teropa
Copy link
Contributor Author

teropa commented May 2, 2016

@wardbell This is now out of date. I'll need to rebase it.

@teropa teropa force-pushed the devguide-upgrade-phonecat-sync branch from eb9d9bd to 11b8e2e Compare May 12, 2016 14:25
@teropa teropa changed the title WIP docs(ugprade): bring phonecat upgrade tutorial up to speed with modernized Angular 1.x PhoneCat docs(ugprade): bring phonecat upgrade tutorial up to speed with modernized Angular 1.x PhoneCat May 12, 2016
@teropa
Copy link
Contributor Author

teropa commented May 12, 2016

@gkalpak We're now up-to-date with rc.1 and new world packacing here. Ready when you are! 😄

@teropa
Copy link
Contributor Author

teropa commented May 23, 2016

@gkalpak @petebacondarwin Would you mind if we land this on angular.io ahead of you?

I'm off for vacation after next week and would like to get this and a few other changes to the ugprade guide in before that.

@petebacondarwin
Copy link
Contributor

Just checking with @gkalpak - there may be a couple of small changes that need to be accommodated before we merge the tutorial PR. Will let you know before tomorrow

@gkalpak
Copy link
Member

gkalpak commented May 24, 2016

@teropa, the main PRs have landed. You are good to go 😃
A couple minor modifications might be necessary (e.g. we introduced ! as the hash-prefix; see this commit). I could take care of these minor modifications to the upgrade guide after this is merged, if you want me to.

@teropa
Copy link
Contributor Author

teropa commented May 24, 2016

@gkalpak Great, thanks! I'm working through some other changes to upgrade, so I can take care of the additional changes as well.

@teropa
Copy link
Contributor Author

teropa commented May 28, 2016

Closing this unmerged. The required changes are covered in #1538

@teropa teropa closed this May 28, 2016
@teropa teropa deleted the devguide-upgrade-phonecat-sync branch October 31, 2016 11:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants