This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(dart): convert toh-3 to Dart #1071
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| --> | ||
| :marked | ||
| We begin by importing the Angular `core.dart` file, | ||
| so that we can use common types like `@Component` when we create |
There was a problem hiding this comment.
Hmm, the type is actually Component instead of Component. If you use it with @ it would probably be better to use @Component() (with ())
There was a problem hiding this comment.
I know what you mean, but it's pretty standard to not include the (). (E.g. https://www.dartlang.org/docs/dart-up-and-running/ch03.html refers to "a @MirrorsUsed annotation". Then again, https://www.dartlang.org/articles/reflection-with-mirrors/ just says "MirrorsUsed annotation".
I'll keep an eye out for whether people are confused by this. I like the clue that @ provides, but resisted putting more characters after the classname...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #700 by @kasperpeulen.