docs:(Tour of Hero Chapter - Http)

[thelgevold]

@wardbell @johnpapa @Foxandxss @filipesilva
I am creating a new PR for my TOH Http chapter due to an issue with my original branch.
Your previous comments can be found here: #1044

I consider this ready for review now, so please let me know if there is anything I should change.

As we discusses I am sticking to promises, but mention that alternatives like Observables exist. I am happy add to this if you think we need more details about Observables since I don't really cover details about them beyond acknowledging their existence :-)

I am using the in memory web api, but link to the appendix in the http developer guide for the configuration details. Let me know if we need to bring more of the details into the TOH guide.

Thanks,
Tor

[Foxandxss]

Sure, let me read it and I will comment out the little details I see

[Foxandxss]

I love this "callbacks" to previous content as a recap but about this one... I guess that the user will have this HeroService open from his work through the tutorial so she/he can see the function you are talking about. Problem I see is that the link sends you to the entire document instead of showing the concrete piece you are talking about.

Personally I would give a better link or simply +makeExample using the toh-4 source and showing it directly.

Thoughts?

[Foxandxss]

So I read it, very nice, I like it. I left you a few comments but let's see what @wardbell has to say about them.

The only part I found more problematic is the "Integration with Http" one. I love what we are doing with the tutorial, about going the "the whole nine yards" (explaining everything) and that part is a bit rushed.

To be honest, I am not sure what to do here. Perhaps I would add a few snippets in how you import all the needed stuff and how I apply them (including the in memory stuff). Give a little explanation (basically the one you put about not using a real http server but an in memory one) and put a subsection linking to the detailed documentation.

The idea is to not force the user to go to another page to complete the tutorial.

WDYT?

[thelgevold]

Thanks for your feedback @Foxandxss .

I have made a few tweaks based on your suggestions.
-Included the function declaration in the snippers
-used underscore for private methods
-called out the save method in HeroService

I have to think about HTTP_PROVIDERS and maybe provide a snippet for that in isolation . I purposely tried to avoid bringing in too much of the api simulation stuff since I think it might be confusing. My guess is that most users will integrate directly with their own apis so seeing SEED_DATA and XHRBackend in the snippet might confuse them....

[Foxandxss]

I think that it is better to reach some middle ground. Not giving all the details like the attached document nor leaving the user do it by himself. A little information + snippets + link to more details is a good middle ground for me.

I don't think that people have a Heroes API so they are more likely going to do what yo do in the tutorial, so we need to explain them how to do it "our way" and if they want to implement so real backend, they can see that as an exercise.

[thelgevold]

Yeah, I think that is a fair point. I have added a snippet and tried to make it more clear which imports are needed for http in general, and which ones are there just for the simulator.

[Foxandxss]

I think you are missing some words or something in this sentence. That and register it AppComponents' provider array is weird to read.

On the other hand, I think that AppComponents' doesn't have an extra s after the apostrophe in this case.

[Foxandxss]

In my opinion, you did an awesome job with the new change. Not too much nor too little.

[thelgevold]

Thanks! Yeah I fixed the grammar error

[johnpapa]

remove "already". Otherwise love the intro.

[thelgevold]

@naomiblack I believe this is pending final review by @wardbell and @johnpapa

[johnpapa]

I’ll review it this weekend. I’m speaking at 3 sessions, 2 full day workshop,s and filming 4 videos this week … so I’m a bit beat :)

[thelgevold]

That sounds great!

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

[googlebot]

CLAs look good, thanks!

[googlebot]

CLAs look good, thanks!

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

[wardbell]

Well done, Tor! And thanks also to everyone who reviewed it.

I scrubbed and adjusted for our latest thinking about RxJS operators and where to configure the in-memory web api.

I added two more commits:

1. Removed the Tutorial sample code because it is always the latest part in the series. THIS is now the latest in the series. I combined the old Tutorial e2e tests with Tor's for this chapter.

2. Removed the unneeded HeroDetailComponent reference and directive from HeroesComponent as suggested in issue docs(ts/tutorial/routing): Remove HeroDetailComponent in HeroesComponent file #1398.

Merging now.