This repository was archived by the owner on Dec 4, 2017. It is now read-only.
fix(quickref-cookbook): fix broken date test #1062
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| it('should display proper movie data', function () { | ||
| // We check only a few samples | ||
| var expectedSamples = [ | ||
| {row: 0, column: 0, element: 'img', attr: 'src', value: 'images/hero.png', contains: true}, | ||
| {row: 0, column: 2, value: 'Celeritas'}, | ||
| {row: 1, column: 3, value: 'Dec 17, 2015'}, | ||
| {row: 1, column: 3, value: '2015', contains: true}, |
There was a problem hiding this comment.
So it will only fail in Europe one day of the year. LOL. I can live with that.
But this doesn't get to the point which is about whether the date was formatted by the pipe. So I'm going a different way, adding a regex test that will bracket the international date problem.
wardbell
force-pushed
the
fix-quickref-test
branch
2 times, most recently
from
5033f10 to
629c60f
Compare
The date test was failing in different timezones due to dates being localized. This fix makes the test slightly less robust, but guarantees that it will work in every timezone irrespective of differences between the node env timezone and browser timezone.
wardbell
force-pushed
the
fix-quickref-test
branch
from
629c60f to
f67b290
Compare
|
Please verify that my amendment works in your timezone. Thx. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The date test was failing in different timezones due to dates being localized.
This fix makes the test slightly less robust, but guarantees that it will work in every timezone irrespective of differences between the node env timezone and browser timezone.
/cc @wardbell