This repository was archived by the owner on Dec 4, 2017. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
working on text text working on bios more text added plunker added sorted list text formatting hero of the month use labels hero of the month formatting text fixed text added host optional formating text element-ref text updates text updates images fixed image added test text
We are promoting |
Thanks for pointing that out @Foxandxss - I will update if that's the direction we are going in. That said, I am not sure I love that requirement. Mainly because it adds a dependency on Angular 2 where it isn't needed. |
Based on team feedback I have added Injectable to all services for consistency |
This was referenced Mar 28, 2016
Hi Tor -
I'll update this comment as I make more changes. |
Hey Tor - I've made more changes but it's in a broken state. Please don't touch at the moment. |
AARGH. I renamed the branch to all lowercase (our standard), and it closed this PR. Please see continuation PR #1022 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATTENTION: this PR closed (see last comment); continued as PR #1022
@wardbell Adding the DI cookbook. Let me know if this is what you had in mind.
Adding @PascalPrecht as well in case he has time to offer some feedback.