This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(toh-pt4): Fix order of methods #1011
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the ordering of the methods `getHeroes` and `getHeroesSlowly` in the "Take it slow" appendix. The original ordering incorrectly suggested that the reader should swap the new `getHeroesSlowly` method for the existing `getHeroes` method, rather than the other way around.
|
Why do you say "incorrectly"? The text seems correct to me. We're asking the reader to use the "slowly" version instead of the regular version. That's what it means to
The change that you are suggesting would do the opposite ... which makes no sense to me. Help me see what I am missing. |
wardbell
changed the title
|
I would read the phrase "...swap X for Y..." to mean "replace instances of X with instances of Y". I think on further thought that it's the use of the word "swap" that causes the confusion. How would you feel about replacing the sentence with:
This should be obvious from context to an attentive reader, but especially from a tutorial ambiguity of any kind should be avoided. |
|
For what is worth, I agree with James in here. Also I prefer what he said in the last message. Better to add a |
|
I like it. That I can do. I'll make that change as I merge yours (so you get credit ;-)) |
thelgevold
pushed a commit
to IdeaBlade/angular.io
that referenced
this pull request
Apr 9, 2016
closes angular#972 chore(toh): change inputs array for input decorator/hero now a class docs(dart): update to b12 Also update dart_to_js_script_rewriter dependency to ^1.0.1, and change most angular2.dart imports to be core.dart instead. The pipes example broke without the angular2.dart import, so I let it be. The server-communication sample has never worked for me, so I changed it but might have broken it further. closes angular#1007 docs: update to style-guide links closes angular#995 Fixed links to John Papa style guide to new repo location. docs(cb-ts-to-js): add cookbook about applying TypeScript examples to ES5 closes angular#893 docs(dart): change imports from bootstrap.dart to platform/browser.dart closes angular#1013 samples(dart): add info file for dart-doc-syncer to template-syntax closes angular#1018 samples(dart): add link to documentation chapter closes angular#1019 docs(toh-1): remove public access modifiers closes angular#1009 Remove public access modifier on AppComponent properties to be consistent throughout code tutorial docs(dependency-injection): tweak Dart wording closes angular#1017 docs(dart): tweak homepage banner closes angular#1016 docs(quickstart): fixed "hurray" typo. closes angular#1021 docs: update to beta.13 docs(dart/quickstart): merge 2 examples into 1 closes angular#1031 docs(dart): update to beta.13.1 closes angular#1032 Add additional tags to the angular.io dgeni package for the new api doc style proposal. Closes angular#1030 chore: remove angulardart.org link from footer closes angular#1034 fix(api-builder): add missing git package dependency This was causing the api-builder tests to fail chore(typo): quide -> guide in cheatsheets closes angular#1039 docs:Create Tour of Heroes chapter on http some text changes wired up web api text adding saving wired up CRUD remove unused files fixed toggle whitespace text text text updates text text tweaks added tests test fixed button click images fixed test tweaks docs(toh): add missing nav path to diagram per angular#1041 chore: fix typo in ts-to-js intro closes angular#1025 chore(bio): add Deborah's bio closes angular#1024 docs(bio): fixes Jules' bio links closes angular#1027 fix(e2e): fix race condition docs(toh-4): reword the getHeroesSlowly instructions closes angular#1011 rewording to: "replace `_heroService.getHeroes` with `_heroService.getHeroesSlowly`" docs: add DI cookbook chore: replace VSCode-specific settings.json with broadly recommended .editorconfig closes angular#1022 docs(template-syntax): fixed "a id" typo in basics section. closes angular#1048 chore: add "homepage" property to package.json closes angular#1038 docs(testing): update testing to use toh-5 closes angular#1003 docs(unit-testing): fix the path to node_modules & steps for adding a new spec closes angular#1043 package(harp): update harp version to fix async errors docs(component-styles): add chapter about styling components closes angular#1047 docs(lifecycle-hooks): Fixed missing ":marked" typo closes angular#1051 docs(todo app): replace remaining tasks reduce func with filter.length closes angular#1050 docs(component-styles): mark `__moduleName` experimental; use alert instead of callout. closes angular#1054 docs(pipes): Fixed "If follows..." typo closes angular#1053 Fixed typo in **pipes** section of guide. chore: update to beta.14
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the ordering of the methods
getHeroesandgetHeroesSlowlyin the "Take it slow" appendix.The original ordering incorrectly suggested that the reader should swap the new
getHeroesSlowlymethod for the existing
getHeroesmethod, rather than the other way around.