Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

In Dart QS: angular2-getting-started -> angular2_getting_started #378

Closed
kwalrath opened this issue Nov 16, 2015 · 3 comments
Closed

In Dart QS: angular2-getting-started -> angular2_getting_started #378

kwalrath opened this issue Nov 16, 2015 · 3 comments
Assignees
@kwalrath
Labels
dart

Comments

@kwalrath
Copy link
Contributor

Dart style is to use _s in names, not -s.

Visible in http://localhost:3000/docs/dart/latest/quickstart.html, source files presumably pulled in from _examples directory.
@kwalrath kwalrath self-assigned this Nov 16, 2015
@kwalrath kwalrath added the dart label Jun 3, 2016
@chalin
Copy link
Contributor

chalin commented Jun 29, 2016

While the original problem reported by this issue seems to be gone, we still name the project folder as angular2-quickstart. Maybe it should be angular2_quickstart, or better yet, just quickstart, thus matching the angular-examples project name.

Whatever we decide, the name should match that given in the pubspec.yaml.

@chalin
Copy link
Contributor

chalin commented Jun 29, 2016

Actually, if we follow what is used for the Tour of Heroes, then the name angular2_quickstart is what is most appropriate. Opting for that.

chalin added a commit to chalin/angular.io that referenced this issue Jun 29, 2016
@chalin
docs(dart/{quickstart,toh-[56]}): fix project names
9243cde 
- Renamed `angular2_getting_started` to `angular2_quickstart` (to match
TS).
- s/-/_/g in project names elsewhere (only toh-5 & -6 needed to be
updated).

Fixes angular#378.
@chalin chalin mentioned this issue Jun 29, 2016
Merged
chalin added a commit to chalin/angular.io that referenced this issue Jun 30, 2016
@chalin
docs(dart/{quickstart,toh-[56]}): fix project names
215ef42 
- Renamed `angular2_getting_started` to `angular2_quickstart` (to match
TS).
- s/-/_/g in project names elsewhere (only toh-5 & -6 needed to be
updated).

Fixes angular#378.
@kwalrath
Copy link
Contributor Author

kwalrath commented Jul 1, 2016

Thanks!

@kwalrath kwalrath closed this as completed Jul 1, 2016
kwalrath pushed a commit that referenced this issue Jul 1, 2016
@chalin @kwalrath
docs(dart/{quickstart,toh-[56]}): fix project names (#1773)
0ba3d5d 
- Renamed `angular2_getting_started` to `angular2_quickstart` (to match
TS).
- s/-/_/g in project names elsewhere (only toh-5 & -6 needed to be
updated).

Fixes #378.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kwalrath kwalrath

Labels
dart
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kwalrath @chalin