-
Notifications
You must be signed in to change notification settings - Fork 877
Mistake on bad-alternative example #3086
Comments
I don't think you'll convince us but, as your suggestion is about Angular, not the Angular docs, you must post it as an issue on the angular website. |
I probably explained myself poorly. I didn't make any suggestion about Angular, but rather I pointed an error existing on Angular docs https://angular.io/docs/ts/latest/guide/hierarchical-dependency-injection.html. The correct solution is: As you write on the live example mention on that page. |
OH MY! You are absolutely right. Thanks for catching that. Fixing. See PR #3091 |
…ther tweaks closes angular#3086 sample reworked to conform to our sample style, to make more sense, and cover the examples discussed copy edits to bring closer to Google docs standards.
…ther tweaks closes angular#3086 sample reworked to conform to our sample style, to make more sense, and cover the examples discussed copy edits to bring closer to Google docs standards.
) * closes #3086 * samples reworked to conform to our sample style, make more sense, and cover the points in prose. * copy edits to bring closer to Google docs standards.
…ore (angular#3091) * closes angular#3086 * samples reworked to conform to our sample style, make more sense, and cover the points in prose. * copy edits to bring closer to Google docs standards.
On https://angular.io/docs/ts/latest/guide/hierarchical-dependency-injection.html, the example of a bad-alternative has an error with the declarations and bootstrap.
I think it is changed.
I know it's a bad alternative and should not be used, but I still think it should be correct.
// Don't do this!
@NgModule({
imports: [
BrowserModule,
FormsModule
],
providers: [ HeroesService, RestoreService ],
declarations: [ HeroesListComponent ],
bootstrap: [
HeroesListComponent,
HeroCardComponent,
HeroEditorComponent
]
})
The text was updated successfully, but these errors were encountered: