Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Tour of Heroes - HTTP - create method for HeroService never defined #2231

Closed
jzissu opened this issue Aug 31, 2016 · 1 comment · Fixed by #2264
Closed

Tour of Heroes - HTTP - create method for HeroService never defined #2231

jzissu opened this issue Aug 31, 2016 · 1 comment · Fixed by #2264

Comments

@jzissu
Copy link

jzissu commented Aug 31, 2016

In the Tour of Heroes, the HTTP page has a section called "Add a hero" where the user makes a new button that will create a new hero using a name entered in an input field on the Heroes page of the application. However when following the steps in the tutorial it doesn't work because they never tell you to add the create method to the HeroService class, which means that when the Add button is clicked the function being called doesn't exist. Now looking at the bottom of the page will show the method, and looking at the Plunkr page also has the method, but you should add the create method to the explanation for that section.

@bignimbus
Copy link

If no one else is working on this, I can submit a fix for this issue.

bignimbus added a commit to bignimbus/angular.io that referenced this issue Sep 2, 2016
- add short blurb explaining HeroService#create
- include HeroService#create snippet
wardbell added a commit to IdeaBlade/angular.io that referenced this issue Sep 3, 2016
fixes angular#2231
also addresses `<h1>` issue raised in PR angular#2256
wardbell added a commit that referenced this issue Sep 3, 2016
fixes #2231
also addresses `<h1>` issue raised in PR #2256
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants