Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

[Dart][example] tutorial/toh-4: styles look wrong #1609

Closed
kwalrath opened this issue Jun 6, 2016 · 1 comment · Fixed by #1936
Closed

[Dart][example] tutorial/toh-4: styles look wrong #1609

kwalrath opened this issue Jun 6, 2016 · 1 comment · Fixed by #1936
Labels
dart example

Comments

@kwalrath
Copy link
Contributor

kwalrath commented Jun 6, 2016

When you go to http://angular-examples.github.io/toh-4/, it uses a serif font. All the other TOH examples (such as http://angular-examples.github.io/toh-3/) use a san-serif font and different spacing/color.

It looks like styles.css is in the repo but not used. Perhaps copy index.html from another sample?
@kwalrath
Copy link
Contributor Author

kwalrath commented Jun 6, 2016

cc @chalin

chalin added a commit to chalin/angular.io that referenced this issue Jun 28, 2016
@chalin
example(toh-4/dart): add missing title and styles link
451956a 
Fixes angular#1609. Now `index.html` matches the other parts, such as that of
toh-3.
@chalin chalin mentioned this issue Jun 28, 2016
Closed
chalin added a commit to chalin/angular.io that referenced this issue Jun 29, 2016
@chalin
example(toh-4/dart): add missing title and styles link
0799eb1 
Fixes angular#1609. Now `index.html` matches the other parts, such as that of
toh-3.
chalin added a commit to chalin/angular.io that referenced this issue Jun 29, 2016
@chalin
test(toh-[234]): add e2e for Dart and TS
90d9bc2 
From the user's perspective toh-2 to -4 all have the same behavior.
This PR introduces e2e tests for all these parts by sharing test suites.

3 minor bugs were detected by the tests and are fixed in this PR.

The toh-1 tests introduced in angular#1620 are
- Refactored so as to be easier to reuse for the other parts.
- Rewritten to benefit from the availability of async/await.

Suites passed:
 - public/docs/_examples/toh-1/dart
 - public/docs/_examples/toh-1/ts
 - public/docs/_examples/toh-2/dart
 - public/docs/_examples/toh-2/ts
 - public/docs/_examples/toh-3/dart
 - public/docs/_examples/toh-3/ts
 - public/docs/_examples/toh-4/dart
 - public/docs/_examples/toh-4/ts

Contributes to angular#1619.

Fixes angular#1609.
Now the toh-4 index.html is identical to those of the previous parts.
chalin added a commit to chalin/angular.io that referenced this issue Jun 29, 2016
@chalin
test(toh-[234]): add e2e for Dart and TS
fa01120 
From the user's perspective toh-2 to -4 all have the same behavior.
This PR introduces e2e tests for all these parts by sharing test suites.

**3 minor bugs** were detected by the tests and are fixed in this PR.

The toh-1 tests introduced in angular#1620 are
- Refactored so as to be easier to reuse for the other parts.
- Rewritten to benefit from the availability of async/await.

Suites passed:
 - public/docs/_examples/toh-1/dart
 - public/docs/_examples/toh-1/ts
 - public/docs/_examples/toh-2/dart
 - public/docs/_examples/toh-2/ts
 - public/docs/_examples/toh-3/dart
 - public/docs/_examples/toh-3/ts
 - public/docs/_examples/toh-4/dart
 - public/docs/_examples/toh-4/ts

Contributes to angular#1619.

Fixes angular#1609.
Now the toh-4 index.html is identical to those of the previous parts.
@chalin chalin mentioned this issue Jun 29, 2016
Closed
chalin added a commit to chalin/angular.io that referenced this issue Jun 30, 2016
@chalin
example(toh-4/dart): add missing title and styles link
892de21 
Fixes angular#1609. Now `index.html` matches the other parts, such as that of
toh-3.
chalin added a commit to chalin/angular.io that referenced this issue Jun 30, 2016
@chalin
test(toh-[234]): add e2e for Dart and TS
e321be7 
From the user's perspective toh-2 to -4 all have the same behavior.
This PR introduces e2e tests for all these parts by sharing test suites.

**3 minor bugs** were detected by the tests and are fixed in this PR.

The toh-1 tests introduced in angular#1620 are
- Refactored so as to be easier to reuse for the other parts.
- Rewritten to benefit from the availability of async/await.

Suites passed:
 - public/docs/_examples/toh-1/dart
 - public/docs/_examples/toh-1/ts
 - public/docs/_examples/toh-2/dart
 - public/docs/_examples/toh-2/ts
 - public/docs/_examples/toh-3/dart
 - public/docs/_examples/toh-3/ts
 - public/docs/_examples/toh-4/dart
 - public/docs/_examples/toh-4/ts

Contributes to angular#1619.

Fixes angular#1609.
Now the toh-4 index.html is identical to those of the previous parts.
chalin added a commit to chalin/angular.io that referenced this issue Jul 1, 2016
@chalin
test(toh-[234]): add e2e for Dart and TS
befb0a8 
From the user's perspective toh-2 to -4 all have the same behavior.
This PR introduces e2e tests for all these parts by sharing test suites.

**3 minor bugs** were detected by the tests and are fixed in this PR.

The toh-1 tests introduced in angular#1620 are
- Refactored so as to be easier to reuse for the other parts.
- Rewritten to benefit from the availability of async/await.

Suites passed:
 - public/docs/_examples/toh-1/dart
 - public/docs/_examples/toh-1/ts
 - public/docs/_examples/toh-2/dart
 - public/docs/_examples/toh-2/ts
 - public/docs/_examples/toh-3/dart
 - public/docs/_examples/toh-3/ts
 - public/docs/_examples/toh-4/dart
 - public/docs/_examples/toh-4/ts

Contributes to angular#1619.

Fixes angular#1609.
Now the toh-4 index.html is identical to those of the previous parts.
chalin added a commit to chalin/angular.io that referenced this issue Jul 1, 2016
@chalin
test(toh-[234]): add e2e for Dart and TS
d812f01 
From the user's perspective toh-2 to -4 all have the same behavior.
This PR introduces e2e tests for all these parts by sharing test suites.

**3 minor bugs** were detected by the tests and are fixed in this PR.

The toh-1 tests introduced in angular#1620 are
- Refactored so as to be easier to reuse for the other parts.
- Rewritten to benefit from the availability of async/await.

Suites passed:
 - public/docs/_examples/toh-1/dart
 - public/docs/_examples/toh-1/ts
 - public/docs/_examples/toh-2/dart
 - public/docs/_examples/toh-2/ts
 - public/docs/_examples/toh-3/dart
 - public/docs/_examples/toh-3/ts
 - public/docs/_examples/toh-4/dart
 - public/docs/_examples/toh-4/ts

Contributes to angular#1619.

Fixes angular#1609.
Now the toh-4 index.html is identical to those of the previous parts.
chalin added a commit to chalin/angular.io that referenced this issue Jul 2, 2016
@chalin
test(toh-[234]): add e2e for Dart and TS
4131f9b 
From the user's perspective toh-2 to -4 all have the same behavior.
This PR introduces e2e tests for all these parts by sharing test suites.

**3 minor bugs** were detected by the tests and are fixed in this PR.

The toh-1 tests introduced in angular#1620 are
- Refactored so as to be easier to reuse for the other parts.
- Rewritten to benefit from the availability of async/await.

Suites passed:
 - public/docs/_examples/toh-1/dart
 - public/docs/_examples/toh-1/ts
 - public/docs/_examples/toh-2/dart
 - public/docs/_examples/toh-2/ts
 - public/docs/_examples/toh-3/dart
 - public/docs/_examples/toh-3/ts
 - public/docs/_examples/toh-4/dart
 - public/docs/_examples/toh-4/ts

Contributes to angular#1619.

Fixes angular#1609.
Now the toh-4 index.html is identical to those of the previous parts.
chalin added a commit to chalin/angular.io that referenced this issue Jul 3, 2016
@chalin
test(toh-[234]): add e2e for Dart and TS
ffb263c 
From the user's perspective toh-2 to -4 all have the same behavior.
This PR introduces e2e tests for all these parts by sharing test suites.

**3 minor bugs** were detected by the tests and are fixed in this PR.

The toh-1 tests introduced in angular#1620 are
- Refactored so as to be easier to reuse for the other parts.
- Rewritten to benefit from the availability of async/await.

Suites passed:
 - public/docs/_examples/toh-1/dart
 - public/docs/_examples/toh-1/ts
 - public/docs/_examples/toh-2/dart
 - public/docs/_examples/toh-2/ts
 - public/docs/_examples/toh-3/dart
 - public/docs/_examples/toh-3/ts
 - public/docs/_examples/toh-4/dart
 - public/docs/_examples/toh-4/ts

Contributes to angular#1619.

Fixes angular#1609.
Now the toh-4 index.html is identical to those of the previous parts.
chalin added a commit to chalin/angular.io that referenced this issue Jul 4, 2016
@chalin
test(toh-[234]): add e2e for Dart and TS
571cbf8 
From the user's perspective toh-2 to -4 all have the same behavior.
This PR introduces e2e tests for all these parts by sharing test suites.

**3 minor bugs** were detected by the tests and are fixed in this PR.

The toh-1 tests introduced in angular#1620 are
- Refactored so as to be easier to reuse for the other parts.
- Rewritten to benefit from the availability of async/await.

Suites passed:
 - public/docs/_examples/toh-1/dart
 - public/docs/_examples/toh-1/ts
 - public/docs/_examples/toh-2/dart
 - public/docs/_examples/toh-2/ts
 - public/docs/_examples/toh-3/dart
 - public/docs/_examples/toh-3/ts
 - public/docs/_examples/toh-4/dart
 - public/docs/_examples/toh-4/ts

Contributes to angular#1619.

Fixes angular#1609.
Now the toh-4 index.html is identical to those of the previous parts.
chalin added a commit to chalin/angular.io that referenced this issue Jul 6, 2016
@chalin
test(toh-[234]): add e2e for Dart and TS
4418965 
From the user's perspective toh-2 to -4 all have the same behavior.
This PR introduces e2e tests for all these parts by sharing test suites.

**3 minor bugs** were detected by the tests and are fixed in this PR.

The toh-1 tests introduced in angular#1620 are
- Refactored so as to be easier to reuse for the other parts.
- Rewritten to benefit from the availability of async/await.

Suites passed:
 - public/docs/_examples/toh-1/dart
 - public/docs/_examples/toh-1/ts
 - public/docs/_examples/toh-2/dart
 - public/docs/_examples/toh-2/ts
 - public/docs/_examples/toh-3/dart
 - public/docs/_examples/toh-3/ts
 - public/docs/_examples/toh-4/dart
 - public/docs/_examples/toh-4/ts

Contributes to angular#1619.

Fixes angular#1609.
Now the toh-4 index.html is identical to those of the previous parts.
chalin added a commit to chalin/angular.io that referenced this issue Jul 8, 2016
@chalin
test(toh-[234]): add e2e for Dart and TS
8e9e181 
From the user's perspective toh-2 to -4 all have the same behavior.
This PR introduces e2e tests for all these parts by sharing test suites.

**3 minor bugs** were detected by the tests and are fixed in this PR.

The toh-1 tests introduced in angular#1620 are
- Refactored so as to be easier to reuse for the other parts.
- Rewritten to benefit from the availability of async/await.

Suites passed:
 - public/docs/_examples/toh-1/dart
 - public/docs/_examples/toh-1/ts
 - public/docs/_examples/toh-2/dart
 - public/docs/_examples/toh-2/ts
 - public/docs/_examples/toh-3/dart
 - public/docs/_examples/toh-3/ts
 - public/docs/_examples/toh-4/dart
 - public/docs/_examples/toh-4/ts

Contributes to angular#1619.

Fixes angular#1609.
Now the toh-4 index.html is identical to those of the previous parts.
chalin added a commit to chalin/angular.io that referenced this issue Jul 12, 2016
@chalin
test(toh-[234]): add e2e for Dart and TS
ade5a64 
From the user's perspective toh-2 to -4 all have the same behavior.
This PR introduces e2e tests for all these parts by sharing test suites.

**3 minor bugs** were detected by the tests and are fixed in this PR.

The toh-1 tests introduced in angular#1620 are
- Refactored so as to be easier to reuse for the other parts.
- Rewritten to benefit from the availability of async/await.

Suites passed:
 - public/docs/_examples/toh-1/dart
 - public/docs/_examples/toh-1/ts
 - public/docs/_examples/toh-2/dart
 - public/docs/_examples/toh-2/ts
 - public/docs/_examples/toh-3/dart
 - public/docs/_examples/toh-3/ts
 - public/docs/_examples/toh-4/dart
 - public/docs/_examples/toh-4/ts

Contributes to angular#1619.

Fixes angular#1609.
Now the toh-4 index.html is identical to those of the previous parts.
chalin added a commit to chalin/angular.io that referenced this issue Jul 12, 2016
@chalin
test(toh-[234]): add e2e for Dart and TS
d0e33cb 
From the user's perspective toh-2 to -4 all have the same behavior.
This PR introduces e2e tests for all these parts by sharing test suites.

**3 minor bugs** were detected by the tests and are fixed in this PR.

The toh-1 tests introduced in angular#1620 are
- Refactored so as to be easier to reuse for the other parts.
- Rewritten to benefit from the availability of async/await.

Suites passed:
 - public/docs/_examples/toh-1/dart
 - public/docs/_examples/toh-1/ts
 - public/docs/_examples/toh-2/dart
 - public/docs/_examples/toh-2/ts
 - public/docs/_examples/toh-3/dart
 - public/docs/_examples/toh-3/ts
 - public/docs/_examples/toh-4/dart
 - public/docs/_examples/toh-4/ts

Contributes to angular#1619.

Fixes angular#1609.
Now the toh-4 index.html is identical to those of the previous parts.
chalin added a commit to chalin/angular.io that referenced this issue Jul 15, 2016
@chalin
test(toh-[234]): add e2e for Dart and TS
41062a6 
From the user's perspective toh-2 to -4 all have the same behavior.
This PR introduces e2e tests for all these parts by sharing test suites.

**3 minor bugs** were detected by the tests and are fixed in this PR.

The toh-1 tests introduced in angular#1620 are
- Refactored so as to be easier to reuse for the other parts.
- Rewritten to benefit from the availability of async/await.

Suites passed:
 - public/docs/_examples/toh-1/dart
 - public/docs/_examples/toh-1/ts
 - public/docs/_examples/toh-2/dart
 - public/docs/_examples/toh-2/ts
 - public/docs/_examples/toh-3/dart
 - public/docs/_examples/toh-3/ts
 - public/docs/_examples/toh-4/dart
 - public/docs/_examples/toh-4/ts

Contributes to angular#1619.

Fixes angular#1609.
Now the toh-4 index.html is identical to those of the previous parts.
chalin added a commit to chalin/angular.io that referenced this issue Jul 17, 2016
@chalin
test(toh-[234]): add e2e for Dart and TS
e5cdeaf 
From the user's perspective toh-2 to -4 all have the same behavior.
This PR introduces e2e tests for all these parts by sharing test suites.

**3 minor bugs** were detected by the tests and are fixed in this PR.

The toh-1 tests introduced in angular#1620 are
- Refactored so as to be easier to reuse for the other parts.
- Rewritten to benefit from the availability of async/await.

Suites passed:
 - public/docs/_examples/toh-1/dart
 - public/docs/_examples/toh-1/ts
 - public/docs/_examples/toh-2/dart
 - public/docs/_examples/toh-2/ts
 - public/docs/_examples/toh-3/dart
 - public/docs/_examples/toh-3/ts
 - public/docs/_examples/toh-4/dart
 - public/docs/_examples/toh-4/ts

Contributes to angular#1619.

Fixes angular#1609.
Now the toh-4 index.html is identical to those of the previous parts.
chalin added a commit to chalin/angular.io that referenced this issue Jul 20, 2016
@chalin
test(toh-[234]): add e2e for Dart and TS
1b0fafe 
From the user's perspective toh-2 to -4 all have the same behavior.
This PR introduces e2e tests for all these parts by sharing test suites.

**3 minor bugs** were detected by the tests and are fixed in this PR.

The toh-1 tests introduced in angular#1620 are
- Refactored so as to be easier to reuse for the other parts.
- Rewritten to benefit from the availability of async/await.

Suites passed:
 - public/docs/_examples/toh-1/dart
 - public/docs/_examples/toh-1/ts
 - public/docs/_examples/toh-2/dart
 - public/docs/_examples/toh-2/ts
 - public/docs/_examples/toh-3/dart
 - public/docs/_examples/toh-3/ts
 - public/docs/_examples/toh-4/dart
 - public/docs/_examples/toh-4/ts

Contributes to angular#1619.

Fixes angular#1609.
Now the toh-4 index.html is identical to those of the previous parts.
chalin added a commit to IdeaBlade/angular.io that referenced this issue Jul 20, 2016
@chalin
examples(tutorial): misc fixes to issues from failed e2e
738b550 
Misc fixes to problems with the tutorial examples, as detected by the new e2e tests. Now the toh-4 index.html is identical to those of the previous parts.

Fixes angular#1609.
@chalin chalin mentioned this issue Jul 20, 2016
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
dart example
Projects
None yet
Milestone
No milestone
1 participant
@kwalrath