Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Missing instructions for how to update to angularjs 1.7 #439

Closed
binki opened this issue Aug 31, 2018 · 1 comment
Closed

Missing instructions for how to update to angularjs 1.7 #439

binki opened this issue Aug 31, 2018 · 1 comment

Comments

@binki
Copy link

binki commented Aug 31, 2018

Hi,

At the 1.7.3 docs tutorial, it recommends to use this repository. However, when I run npm install, it gives me angularjs-1.5.x. Also, I read the README and it says:

Since the Angular framework library code and tools are acquired through package managers (npm and bower) you can use these tools to easily update the dependencies. Simply run the preconfigured script:

npm run update-deps

But when I do that, it says something like the following indicating that it is staying within 1.5 because they are ~ dependencies:

ohnobinki@gibby ~/public_html/angularjs-location-path $ npm run update-deps

> [email protected] update-deps /home/ohnobinki/public_html/angularjs-location-path
> npm update


> [email protected] postupdate-deps /home/ohnobinki/public_html/angularjs-location-path
> bower update

bower cached        https://github.com/angular/bower-angular-loader.git#1.5.11
bower validate      1.5.11 against https://github.com/angular/bower-angular-loader.git#~1.5.0
bower cached        https://github.com/angular/bower-angular.git#1.5.11
bower validate      1.5.11 against https://github.com/angular/bower-angular.git#~1.5.0
bower cached        https://github.com/h5bp/html5-boilerplate.git#5.3.0
bower validate      5.3.0 against https://github.com/h5bp/html5-boilerplate.git#^5.3.0
bower cached        https://github.com/angular/bower-angular-mocks.git#1.5.11
bower validate      1.5.11 against https://github.com/angular/bower-angular-mocks.git#~1.5.0
bower cached        https://github.com/angular/bower-angular-route.git#1.5.11
bower validate      1.5.11 against https://github.com/angular/bower-angular-route.git#~1.5.0

Could the README be updated to explain how to manually do a major (in AngularJS, 1.2 to 1.3 is considered major because it doesn’t use semver which explains why it is using ~ instead of ^ for dependencies) update?

gkalpak added a commit to gkalpak/angular.js that referenced this issue Nov 2, 2018
@gkalpak gkalpak closed this as completed in 21a3c93 Nov 2, 2018
@gkalpak
Copy link
Member

gkalpak commented Nov 2, 2018

I also added a note about upgrading in the tutorial (in angular/angular.js#16753).

gkalpak added a commit to gkalpak/angular.js that referenced this issue Nov 2, 2018
gkalpak added a commit to gkalpak/angular.js that referenced this issue Nov 5, 2018
gkalpak added a commit to angular/angular.js that referenced this issue Nov 15, 2018
gkalpak added a commit to angular/angular.js that referenced this issue Nov 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants