Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

chore: update the codebase (e.g. directory layout, file naming etc) #334

Closed
3 of 5 tasks
gkalpak opened this issue Apr 12, 2016 · 4 comments
Closed
3 of 5 tasks

chore: update the codebase (e.g. directory layout, file naming etc) #334

gkalpak opened this issue Apr 12, 2016 · 4 comments

Comments

@gkalpak
Copy link
Member

gkalpak commented Apr 12, 2016

Once/If #341 is merged, it would be a good idea to update the code organization to adhere to latest best practices™ and bring the seed closer to the tutorial (see angular/angular-phonecat#326). E.g.:

  • Rename components/ to core/ or common/.
    Now that "components" means something different, it can be confusing.
  • Rename _test.js files to .spec.js.
  • Rename module definitions files to .module.js.
  • Update karma.conf.js to account for the above changes.
  • Optionally, use components when appropriate.
gkalpak added a commit to gkalpak/angular-seed that referenced this issue Aug 25, 2016
gkalpak added a commit to gkalpak/angular-seed that referenced this issue Oct 26, 2018
gkalpak added a commit to gkalpak/angular-seed that referenced this issue Oct 26, 2018
@gkalpak
Copy link
Member Author

gkalpak commented Oct 26, 2018

Some of the points above will be addressed in #444.
We won't be making more changes now that AngularJS is in LTS mode.

@petebacondarwin
Copy link
Contributor

Core makes it sound like it is part of AngularJS no? I could live with common or shared

@gkalpak
Copy link
Member Author

gkalpak commented Oct 30, 2018

I personally prefer shared as well, but I tried to lousely follow the Angular style guide. It suggests having a shared directory/module and a core directory/module.
I felt that the type of things we had in components/ was better suited for core/ (but happy to move to shared/ instead).

@petebacondarwin
Copy link
Contributor

I am not going to fight over this one

gkalpak added a commit that referenced this issue Oct 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants