This repository was archived by the owner on Feb 26, 2024. It is now read-only.

function angular.$$minErr is trimmed to $minErr when run update-index-async #283

Closed

jerryorta-dev opened this issue Jul 8, 2015 · 0 comments

jerryorta-dev commented Jul 8, 2015

When running npm run update-index-async, $$minErr is trimmed to $minErr when angular-loader.min.js is copied to index-async.html

The text was updated successfully, but these errors were encountered:

jerryorta-dev mentioned this issue

fix(packageJson): #283 change trimmed minErr #286

Closed

gkalpak added a commit to gkalpak/angular-seed that referenced this issue


          fix(index-async): properly inline text containing $$

d55058d

When using `'...'.replace(regex, replacement)`, any instances of `$$` inside `replacement` will be
converted to `$` (see
[mdn](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace#Specifying_a_string_as_a_parameter).
Thus, for example `$$minErr` and `$$moduleName` are converted to `$minErr` and `$moduleName`.
This commit fixes it, by first converting `$$` to `$$$$`.

Fixes angular#283
Closes angular#286

gkalpak mentioned this issue

fix(index-async): fix inlining of angular-loader into index-async.html #343

Closed

gkalpak added a commit to gkalpak/angular-seed that referenced this issue


          fix(index-async): properly inline text containing $$

d7083e8

When using `'...'.replace(regex, replacement)`, any instances of `$$` inside `replacement` will be
converted to `$` (see
[mdn](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace#Specifying_a_string_as_a_parameter).
Thus, for example `$$minErr` and `$$moduleName` are converted to `$minErr` and `$moduleName`.
This commit fixes it, by first using `'...'.split(regex).join(replacement)` instead.

Fixes angular#283
Closes angular#286

gkalpak added a commit to gkalpak/angular-seed that referenced this issue


          fix(index-async): properly inline text containing $$

4fc738b

When using `'...'.replace(regex, replacement)`, any instances of `$$` inside `replacement` will be
converted to `$` (see
[mdn](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace#Specifying_a_string_as_a_parameter).
Thus, for example `$$minErr` and `$$moduleName` are converted to `$minErr` and `$moduleName`.
This commit fixes it, by first using `'...'.split(regex).join(replacement)` instead.

Fixes angular#283
Closes angular#286

petebacondarwin closed this as completed in

a223b77

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.