This repository was archived by the owner on Apr 4, 2025. It is now read-only.
refactor(log): Remove log option #84
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really nice cleanup. changes looks good. just waiting for green. |
Now that we've switched to an event emitter, log was no longer used and was causing confusion. The major change here is that once we emit an event, it is not stored. If this turns out to be a big deal, we can implement a message storage module. Closes #81 tweaked test
SomeKittens
force-pushed
the
remove-hint-log
branch
from
fbe8c12 to
c6eb22a
Compare
|
Thanks for the review, @erwinmombay. Brought this into master. |
SomeKittens
added a commit
that referenced
this pull request
Nov 13, 2015
Check for a __ngHintName property on scope/controllerAs value. If found, name the scope that in the Scopes panel. Fixes #84
erwinmombay
pushed a commit
that referenced
this pull request
Mar 7, 2016
Check for a __ngHintName property on scope/controllerAs value. If found, name the scope that in the Scopes panel. Fixes #84
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we've switched to an event emitter, log was no longer used and was causing confusion.
The major change here is that once we emit an event, it is not stored. If this turns out to be a big deal, we can implement a message storage module.
Closes #81