This repository was archived by the owner on Apr 4, 2025. It is now read-only.
fix(scopes) handle watches on null expression #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing null as first parameter to the $scope.$watch function caused a null reference exception within hint.js that interferes with the loading of the users app. Adding a null check to resolve this issue. Fixes issue angular#94
| @@ -304,6 +304,9 @@ function byScopeId (scope) { | |||
| } | |||
|
|
|||
| function humanReadableWatchExpression (fn) { | |||
| if (fn == null) { | |||
There was a problem hiding this comment.
I actually think this is fine since it'll also handle null elegantly.
|
Just the equals thing, otherwise looks great! Thanks again |
|
Hi SomeKittens The intention here is to catch undefined as well as null, as the same bug will occur with undefined. Perhaps i am wrong to always be returning null, might be best to return fn, so it correctly reports what the user passed in - ill change that sure and add a test for the undefined scenario. |
|
Just strictly check for both |
|
I actually prefer @gary-b's way. |
btford
added a commit
that referenced
this pull request
Aug 14, 2015
fix(scopes): handle watches on null expression
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing null as first parameter to the $scope.$watch function caused a null reference exception within hint.js that interferes with the loading of the users app. Adding a null check to resolve this issue.
Fixes issue #94