fix(linter): tslint always exits nicely #974
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the `--force` flag of tslint to always exit the command in success, even if violations are detected. It changes the current behaviour where the command exits in error. See https://github.com/palantir/tslint#usage Fixes angular#967
|
Closed as per #967 (comment) |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
clydin
pushed a commit
to clydin/angular-cli
that referenced
this pull request
Aug 29, 2023
This is another feature that we mentioned in the Eliminate Render Blocking Requests RFC (angular#18730) **Prerendering** To enable critical css inlining for prerendering set the `inlineCritical` to true under the Browser Builder options. Example: ```json "configurations": { "production": { "fileReplacements": [ { "replace": "src/environments/environment.ts", "with": "src/environments/environment.prod.ts" } ], "optimization": { "styles": { "minify": true, "inlineCritical": true, } }, ``` **Express Engine** Update server.ts ```ts server.engine('html', ngExpressEngine({ bootstrap: AppServerModule, inlineCriticalCss: true, })); ``` **Hapi Engine** Update server.ts ```ts server.route({ method: 'GET', path: '/{path*}', handler: (req: Request) => ngHapiEngine({ bootstrap: AppServerModule, documentFilePath, publicPath: distFolder, inlineCriticalCss: true, req, }) }); ``` Inlining of critical CSS is turned off by default. In a future versions of the Angular CLI and Universal inline critical CSS will be enabled by default. Closes angular#974
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the
--forceflag of tslint to always exit the command in success,even if violations are detected. It changes the current behaviour where the command
exits in error. See https://github.com/palantir/tslint#usage
Fixes #967