Skip to content

feat(@angular/cli): disable progress when running outside TTY #8501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2017
Merged

feat(@angular/cli): disable progress when running outside TTY #8501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/documentation/build.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ Note: service worker support is experimental and subject to change.
<details>
<summary>progress</summary>
<p>
<code>--progress</code> (aliases: <code>-pr</code>) <em>default value: true</<em>
<code>--progress</code> (aliases: <code>-pr</code>) <em>default value: true inside TTY, false otherwise</<em>
</p>
<p>
Log progress to the console while building.
Expand Down
2 changes: 1 addition & 1 deletion docs/documentation/eject.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ ng eject
<details>
<summary>progress</summary>
<p>
<code>--progress</code> (aliases: <code>-pr</code>) <em>default value: true</em>
<code>--progress</code> (aliases: <code>-pr</code>) <em>default value: true inside TTY, false otherwise</em>
</p>
<p>
Log progress to the console while building.
Expand Down
2 changes: 1 addition & 1 deletion docs/documentation/serve.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ All the build Options are available in serve, below are the additional options.
<details>
<summary>progress</summary>
<p>
<code>--progress</code> (aliases: <code>-pr</code>) <em>default value: true</em>
<code>--progress</code> (aliases: <code>-pr</code>) <em>default value: true inside TTY, false otherwise</em>
</p>
<p>
Log progress to the console while building.
Expand Down
2 changes: 1 addition & 1 deletion docs/documentation/test.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ You can run tests with coverage via `--code-coverage`. The coverage report will
<details>
<summary>progress</summary>
<p>
<code>--progress</code> <em>default value: true</em>
<code>--progress</code> <em>default value: true inside TTY, false otherwise</em>
</p>
<p>
Log progress to the console while in progress.
Expand Down
2 changes: 1 addition & 1 deletion docs/documentation/xi18n.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
<details>
<summary>progress</summary>
<p>
<code>--progress</code>
<code>--progress</code> <em>default value: true inside TTY, false otherwise</<em>
</p>
<p>
Log progress to the console while running.
Expand Down
4 changes: 3 additions & 1 deletion packages/@angular/cli/commands/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,9 @@ export const baseBuildCommandOptions: any = [
type: Boolean,
aliases: ['pr'],
description: 'Log progress to the console while building.',
default: buildConfigDefaults['progress']
default: typeof buildConfigDefaults['progress'] !== 'undefined'
? buildConfigDefaults['progress']
: process.stdout.isTTY === true
},
{
name: 'i18n-file',
Expand Down
6 changes: 4 additions & 2 deletions packages/@angular/cli/commands/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,10 @@ const TestCommand = Command.extend({
{
name: 'progress',
type: Boolean,
default: testConfigDefaults['progress'],
description: 'Log progress to the console while in progress.'
description: 'Log progress to the console while in progress.',
default: typeof testConfigDefaults['progress'] !== 'undefined'
? testConfigDefaults['progress']
: process.stdout.isTTY === true,
},
{
name: 'browsers',
Expand Down
4 changes: 2 additions & 2 deletions packages/@angular/cli/commands/xi18n.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ const Xi18nCommand = Command.extend({
{
name: 'progress',
type: Boolean,
default: true,
description: 'Log progress to the console while running.'
description: 'Log progress to the console while running.',
default: process.stdout.isTTY === true,
},
{
name: 'app',
Expand Down
3 changes: 1 addition & 2 deletions packages/@angular/cli/lib/config/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,8 +471,7 @@
},
"progress": {
"description": "The ssl key used by the server.",
"type": "boolean",
"default": true
"type": "boolean"
},
"poll": {
"description": "Enable and define the file watching poll time period (milliseconds).",
Expand Down