-
Notifications
You must be signed in to change notification settings - Fork 12k
feat(@angular/cli): add a bundle dependencies flag #7937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
70f0c29
to
51fdccd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One little nit
type: ['none', 'all'], | ||
default: 'none', | ||
description: 'Which external dependencies to bundle into the module. By default, ' | ||
+ 'all of node_modules will be kept as requires.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please clarify that this flag applies only when platform is "server"
This flag allows people who know what theyre doing to bundle the server build together with all dependencies. It should only be used when the whole rendering process is part of the main.ts or one of its dependencies. Fixes angular#7903.
Brilliant - this is much quicker than I expected :) Great work. @hansl Will you also be tweaking the default config so that it doesn't try to uglify server-side builds? Otherwise it will lead to an error when trying to minify a typical self-contained build. Or will this be a different config option? |
@SteveSandersonMS if you use |
@Toxicable Thanks for the suggestion. Unfortunately in 1.5.0 that doesn't seem to be sufficient to avoid build warnings. Have filed a new issue to track that: #8035 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This flag allows people who know what theyre doing to bundle the
server build together with all dependencies. It should only be
used when the whole rendering process is part of the main.ts
or one of its dependencies.
Fixes #7903