fix(@angular/cli): fix import path for component when importing into …

[andrewkww]

…a module

This is similar to 86021a0.

Fix #7135

[hansl]

Hi @andrewkww,

Could you add a test so we prevent readding issue #7135 in the future? Thanks!

[andrewkww]

@hansl Yup, added tests for other blueprints too.

[exequiel09]

Been waiting for this. I hope this PR will be merged soon. Thanks for the awesome work.

[hansl]

We're in the process of moving all our blueprints to Schematics. @Brocco is doing that work in #7090. Let's see if the issue happens still after that PR (some pathing problems were fixed because of the nature of Schematics which is stricter WRT paths).

I'm keeping this PR open but know that it will be obsolete. If the issue still happens, I'll check in with you that you make the change in the proper place on the Schematics repo.

Thakns!

[cyrilletuzi]

@hansl Why not include this PR in 1.3 ? I suppose schematics will have to wait for 1.4, meaning we will stay a more few weeks with this regression (and very annoying) issue.

[andrewkww]

@hansl Given the number of people running into the issue, it seems like a good idea to at least merge the change into 1.3.x.

[andrewkww]

Looks like the issue is now fixed in master. It'd still be good to include the tests that I have, since they test for the issue.

Also, the issue still exists in 1.3.x and 1.4.x. I think it's still a good idea to have the fix applied there. Let me know if you want the fix in those branches, and I can submit a pull request to those branches.

[hansl]

@andrewkww Master is not what's being released in 1.3.0, so this PR might actually skip master and be merged in 1.3.x directly.

[andrewkww]

Yes, but since this PR is set to merge into master, I've removed the patch so that the commits only contains the tests. This should be good to merge into master. If you want the fix for blueprint that I had previously, I can create a separate pull requests, one for 1.3.x and one for 1.4.x.

[hansl]

Please create one for 1.3.x. We will only have the tests for 1.4.x.

[hansl]

@andrewkww I went ahead and did a PR for your 1.3.x branch and merged it. It's going to be out today. Thanks!

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}