Skip to content

test(@ngtools/webpack): add source-map-support. #7191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 31, 2017
Merged

test(@ngtools/webpack): add source-map-support. #7191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
465feb3
test(@ngtools/webpack): add source-map-support.
aecz Jul 28, 2017
0f3b444
test(@ngtools/webpack): add source-map-support to match root package.…
aecz Jul 28, 2017
a520a42
test(@ngtools/webpack): add source-map-support to enumerate.
aecz Jul 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@
"silent-error": "^1.0.0",
"source-map": "^0.5.6",
"source-map-loader": "^0.2.0",
"source-map-support": "^0.4.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this to https://github.com/angular/angular-cli/blob/master/packages/%40angular/cli/package.json as well?

We have several packages being deployed from the same repo so multiple package.json need to be updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency added and also fixed the enumerate in karma.ts.

"style-loader": "^0.13.1",
"stylus": "^0.54.5",
"stylus-loader": "^3.0.1",
Expand Down
1 change: 1 addition & 0 deletions packages/@angular/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
"semver": "^5.1.0",
"silent-error": "^1.0.0",
"source-map-loader": "^0.2.0",
"source-map-support": "^0.4.1",
"istanbul-instrumenter-loader": "^2.0.0",
"style-loader": "^0.13.1",
"stylus": "^0.54.5",
Expand Down
1 change: 1 addition & 0 deletions packages/@angular/cli/plugins/karma.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { KarmaWebpackThrowError } from './karma-webpack-throw-error';
* Enumerate needed (but not require/imported) dependencies from this file
* to let the dependency validator know they are used.
*
* require('source-map-support')
* require('karma-source-map-support')
*/

Expand Down