Skip to content

fix(@ngtools/webpack): fix lazy loading new Error emit after webpack … #6804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rayros
Copy link
Contributor

@rayros rayros commented Jun 26, 2017

…detect lazy module file change

#4326 (comment)

@hansl
Copy link
Contributor

hansl commented Jun 29, 2017

@rayros Could you explain how this relates to the issue you pointed at? That issue is from February and has been fixed.

@rayros
Copy link
Contributor Author

rayros commented Jul 12, 2017

Ok, I create angular 2 project and use lazy loading for some module, when i change something in this module webpack throw the same error which i pointed at description. This error not occurs on the first build.

@rayros
Copy link
Contributor Author

rayros commented Jul 12, 2017

Do you want a example repository?

@JaSpr
Copy link

JaSpr commented Aug 8, 2017

bump

Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase. LGTM.

@JaSpr
Copy link

JaSpr commented Aug 22, 2017

bump

@JaSpr
Copy link

JaSpr commented Aug 25, 2017

@rayros Have you been able to rebase your changes, so that the changes can be merged in?

@rayros rayros closed this Aug 31, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants