Skip to content

feat(@angular/cli): add baseHref property to appConfig #6461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2017

Conversation

lacolaco
Copy link
Contributor

Allows baseHref to be defined in .angular-cli.json.

filipesilva
filipesilva previously approved these changes Jun 1, 2017
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@filipesilva filipesilva self-assigned this Jun 1, 2017
@filipesilva
Copy link
Contributor

@laco0416 I'm sorry, a conflict came up meanwhile, can you rebase please?

@lacolaco
Copy link
Contributor Author

lacolaco commented Jun 8, 2017

@filipesilva done!

@lacolaco lacolaco force-pushed the base-href-config branch from c06bc3b to fdabad2 Compare June 8, 2017 01:30
@Brocco Brocco merged commit 692b378 into angular:master Jun 12, 2017
@lacolaco lacolaco deleted the base-href-config branch June 12, 2017 13:45
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants