refactor(@angular/cli): use memory FS for i18n extraction #6306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocombe
approved these changes
May 16, 2017
There was a problem hiding this comment.
Sounds good to me! 👍
Could you just update the commit message to add the reference to the issue that it fixes? (not the title of the commit, but the description).
Also this is probably more a fix than a refactor, what do you think @filipesilva ?
filipesilva
approved these changes
May 16, 2017
|
Writing to the temp dir wasn't a bug, so I'm fine with refactor. |
sumitarora
pushed a commit
that referenced
this pull request
May 18, 2017
Brocco
pushed a commit
that referenced
this pull request
May 24, 2017
dond2clouds
pushed a commit
to d2clouds/speedray-cli
that referenced
this pull request
Apr 23, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates the need to write and then delete the build output.
memory-fswas an existing transitive dependency that was moved to a direct dependency due to its now explicit usage.