Skip to content

feat(@angular/cli): add publicPath support via command for webpack-dev-server #6112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

scriste-sv
Copy link

This adds support for publicPath to webpack-dev-server via ng serve
The server would have to be started like ng serve --deploy-url /deploypath --base-href /deploypath.
The app will be served from http://localhost:4200/deploypath

Should fix #2727

…i.json for webpack-dev-server

This adds support for publicPath to webpack-dev-server via ng serve
The server would have to be started like ng serve --deploy-url /deploypath --base-href /deploypath.
The app will be served from http://localhost:4200/deploypath

Should fix angular#2727
@scriste-sv
Copy link
Author

@filipesilva could you please review and let me know if this is eligible for to complete the fix on #3285 and address the issues with ng serve?

Thank you.

Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya, thanks so much for adding this! I've wondered for a while if it would work. Cheers!

@filipesilva filipesilva merged commit 8c78fb9 into angular:master May 4, 2017
@scriste-sv scriste-sv deleted the add-public-path-option-for-webpack-dev-server branch May 11, 2017 06:59
@scriste-sv
Copy link
Author

Great, thanks @filipesilva

@josipledic
Copy link

Is it possible to let the port be the port that is specified inside the angular-cli.json? Like this the port 4200 is hard coded :(

@filipesilva
Copy link
Contributor

@ledicjp yes, you can add it in the defaults.serve section. See https://github.com/angular/angular-cli/wiki/angular-cli for details.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants