Skip to content

feat(@angular/cli): add styles/scripts prefix #5844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

avshenuk
Copy link

@avshenuk avshenuk commented Apr 5, 2017

Just for consideration. Add styles/scripts prefix in order to generate styles/scripts into different folders etc.

Just for consideration. Add styles/scripts prefix in order to generate styles/scripts into different folders etc.
@hansl
Copy link
Contributor

hansl commented Apr 7, 2017

What's the use case for this that you're trying to fix?

@avshenuk
Copy link
Author

avshenuk commented Apr 7, 2017 via email

@changLiuUNSW
Copy link
Contributor

changLiuUNSW commented Apr 19, 2017

@avshenuk Be careful, this change will break CSS assets url path if user adds publicPath via deployUrl.
We override publichPath:'' for extractTextPlugin which will only work if CSS and assets are under the same folder but your change will make the CSS and assets under different folder.
#4036

@filipesilva
Copy link
Contributor

filipesilva commented May 8, 2017

Thank you for the work you put into this Pr, but I don't think this change provides enough benefit vs the risk. There's also some overlap with --deploy-url in regards to functionality.

@filipesilva filipesilva closed this May 8, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants