Skip to content

fix(@angular/cli): Update README.md project generation text. #5813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(@angular/cli): Update README.md project generation text. #5813

wants to merge 1 commit into from

Conversation

killrazor
Copy link
Contributor

@killrazor killrazor commented Apr 3, 2017

validate-project-name.ts looks for hypen(-) rather than the listed underscore(_).

angular-cli/packages/@angular/cli/utilities/validate-project-name.ts looks for hypen(-) rather than the listed underscore(_).
@sumitarora
Copy link
Contributor

@killrazor Please fix the commit message fix(@angular/cli): Update README.md project generation text.

Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya, thanks for fixing this. Can you change the commit message though? That's what's breaking the tests.

@killrazor
Copy link
Contributor Author

killrazor commented Apr 11, 2017

Sorry all. I'll have to do this from home tonight as I can't figure out how edit the commit via web.

@killrazor killrazor changed the title Update README.md project generation text. fix(@angular/cli): Update README.md project generation text. Apr 14, 2017
@killrazor
Copy link
Contributor Author

It looks like trying to actually manipulate the commit is going to take more time thank just making a new one. Doing that with a corrected message instead. Sorry. Thanks.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants