Skip to content

fix(@angular/cli): adding multiple apps story #5737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2017

Conversation

sumitarora
Copy link
Contributor

Fixes: #5726


To serve the first app: `ng serve --app=0` or `ng serve --app 0`

To serve the second app: `ng serve --app=1` or `ng serve --app 12`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12? :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@intellix Fixed

Copy link
Contributor

@Brocco Brocco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see the apps objects truncated with ... (partially or completely) as it will likely change and be out of date. Without the full object the story is still valid and will also be shorter and easier to consume.

@sumitarora sumitarora force-pushed the fix-multiple-apps-story branch from 8eacff2 to d6d837b Compare April 17, 2017 19:51
@sumitarora
Copy link
Contributor Author

@Brocco done the changes.

Copy link
Contributor

@Brocco Brocco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this helps the readability of the story, thanks for making the changes!

@abdel-ships-it
Copy link

@Brocco Is there any way to ensure the angular cli generators still work with multiple apps? Im pretty sure you're familiar with the following error

Error locating module for declaration
SilentError: No module files found

According to a few github issues I read it has to do with multiple app module files being in the src directory, is there any recommended way to have a multiple apps setup without breaking the CLI generators?

@cvgaviao
Copy link

cvgaviao commented Nov 30, 2017

Hi, I'm reading #7418 and there is a comment there that says that in order to use multiple app in same project we need to create a new dir src/new-app and copy every file under the src/app to it.
But I can't find any info in the stories-multiple-apps about what should/must be copied and how to set "root" and "outDir" properly.
Also I cannot find anything about how to setup an e2e test when using multiple apps.
Could someone put the right approach info there ?

dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this pull request Apr 23, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Details on how multiple apps are supposed to work
7 participants