Skip to content

fix(@angular/cli): allow the use of a base-href with scheme #5527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Mar 24, 2017
Merged

fix(@angular/cli): allow the use of a base-href with scheme #5527

merged 1 commit into from Mar 24, 2017

Conversation

clydin
Copy link
Member

@clydin clydin commented Mar 20, 2017

followup to #5405

filipesilva
filipesilva approved these changes Mar 21, 2017
View reviewed changes
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job catching this case!

@hansl hansl merged commit 36b8c9b into angular:master Mar 24, 2017
@clydin clydin deleted the absolute-base-href branch March 24, 2017 00:29
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@filipesilva filipesilva filipesilva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clydin @filipesilva @hansl @googlebot