-
Notifications
You must be signed in to change notification settings - Fork 12k
added section on difference between building with or without prod flag #5195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added section on difference between building with or without prod flag #5195
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
CLAs look good, thanks! |
f0ecd02
to
8383d53
Compare
…es when building with prod
8383d53
to
6d08b10
Compare
perhaps a lint warning should be added aswell ? |
…building-with-or-without-prod-flag
BTW, maybe need add something like this:
|
…building-with-or-without-prod-flag
I agree that these differences should be documented, and maybe a new flag to opt-in minification. We can't add this flag now however, and the documentation shouldn't focus so much on the effects of minification however. I'll track this in #5315. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
My team spent a long time figuring out why our code broke when building our project with the
--prod
flag compared to when we did not.Since we don't know much about the build process in angular-cli we did not know what the real difference was when using the flag.
We finally found out that
constructor.name
did not work when building prod.Therefore this pull request contains a warning with example and a "difference" section.
I know that tree shaking is done and uglifying. Is there more that could be added?