docs: correct rc.0 migration guide #5041
Conversation
| @@ -340,6 +343,7 @@ We also updated the scripts section to make it more simple: | |||
| "scripts": { | |||
| "ng": "ng", | |||
| "start": "ng serve", | |||
| "build": "ng build" | |||
There was a problem hiding this comment.
Missing a comma at the end of the line
There was a problem hiding this comment.
Thanks much. I added the missing comma (and rebased to current).
PlatinumEagle
force-pushed
the
docs-rc.0-MigrationGuideFixes
branch
from
7c39b6a to
bec21f8
Compare
|
@filipesilva @hansl This one should really go in : I'm seeing a lot of people struggling to update because of these missing lines... |
|
@PlatinumEagle can you rebase please? |
| @@ -311,20 +311,23 @@ We've updated a lot of packages over the last months in order to keep projects u | |||
|
|
|||
| Additions or removals are found in bold below. | |||
|
|
|||
| `"angular-cli": {},` was **removed** | |||
There was a problem hiding this comment.
This is already listed in line 324.
There was a problem hiding this comment.
@filipesilva What I'm referencing is an "angular-cli" object that the betas put in to the project.json that is outside of the "dependencies" and "devDependencies" objects. In the betas, that line was previously between "license" and "scripts" and in the RC that item no longer exists, so I just included that note so people could clean it up.
Since that extraneous object doesn't currently break anything and we don't want people to confuse it with the line you referenced, I'll take it out of this pull request and rebase as you requested so that the things that are broken can get fixed. Thanks.
There was a problem hiding this comment.
What beta was that though? This guide only covers from beta.24 up and I didn't see that entry there.
PlatinumEagle
force-pushed
the
docs-rc.0-MigrationGuideFixes
branch
from
bec21f8 to
e7d886b
Compare
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
fix test runner dependency and other corrections Closes angular#5039
PlatinumEagle
force-pushed
the
docs-rc.0-MigrationGuideFixes
branch
from
e7d886b to
1a5dd9f
Compare
|
CLAs look good, thanks! |
|
@filipesilva Rebase complete (per your request). |
|
Approved and will be merged soon, thank you for doing these updates! |
fix test runner dependency and other corrections Closes angular#5039 Close angular#5041
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
fix test runner dependency and other corrections
Closes #5039