Skip to content

test: fix commit message test for branches #5004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

filipesilva
Copy link
Contributor

@filipesilva filipesilva commented Feb 25, 2017

For travis runs on branches, local master never exists there's no branch tracking origin/master.

This causes git fetch origin master to fetch into FETCH_HEAD instead of master.

This PR will explicitly fetch origin master into local master, and use that for the log comparison.

/cc @clydin

For travis runs on branches, local master never exists there's no branch
tracking origin/master.

This causes `git fetch origin master` to fetch into `FETCH_HEAD` instead
of master.

This PR will explicitely fetch origin master into local master, and use
that for the log comparison.
@Brocco
Copy link
Contributor

Brocco commented Mar 3, 2017

FYI, I made the change to the wiki itself for the interim.

@filipesilva filipesilva merged commit 48324d1 into angular:master Mar 3, 2017
@filipesilva filipesilva deleted the fix-commit-message-validation branch March 3, 2017 15:24
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
For travis runs on branches, local master never exists there's no branch
tracking origin/master.

This causes `git fetch origin master` to fetch into `FETCH_HEAD` instead
of master.

This PR will explicitely fetch origin master into local master, and use
that for the log comparison.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants