Skip to content

fix(@ngtools/webpack): Bump loader-utils and use getOptions #5001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2017
Merged

fix(@ngtools/webpack): Bump loader-utils and use getOptions #5001

merged 2 commits into from
Mar 1, 2017

Conversation

ryantd
Copy link
Contributor

@ryantd ryantd commented Feb 25, 2017

fix deprecated warning
deprecated-warning

link: webpack/loader-utils#56

@filipesilva
Copy link
Contributor

There's a CI error but it's unrelated to your PR. If you rebase it the error should go away.

@ryantd
Copy link
Contributor Author

ryantd commented Feb 26, 2017

All set~ @filipesilva

@ryantd
Copy link
Contributor Author

ryantd commented Mar 1, 2017

If there is something I need to do, please let me know~

@filipesilva filipesilva merged commit 864d520 into angular:master Mar 1, 2017
@filipesilva
Copy link
Contributor

@ryani33 no, there wasn't anything else you needed to do. Sometimes a bunch of commits are merged together at the same time, that's all.

Thanks for fixing this!

@ryantd ryantd deleted the fix-deprecated-warning branch March 1, 2017 15:22
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants