-
Notifications
You must be signed in to change notification settings - Fork 12k
refactor(@angular/cli): remove compression plugin #4702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3 it!
001068d
to
ab35ccf
Compare
I am a little surprised by this change. One thing I like about Angular-CLI is the way it handles all the steps needed to produce a production-ready deployment output. |
@wulfsberg the reasoning for this change can be found #4618 (comment) No plans of re-introducing it ourselves. Sounds perfectly possible with the upcoming plugin architecture. |
Would not be better then to remove this feature once it's easy to do with the new plugin architecture? |
#4618 (comment) says that there is an easy workaround and asks for documenting how it can be enabled by end users. Where can I find such information? This PR removed the feature, but did not add any docs AFAICT. |
At least give us a flag to enable it ╮(╯▽╰)╭ |
Is there any other ways to compress text files? |
Hello guys! I'm using workaround with gulp.
I added new command into script section of package.json And I added gulpfile.js in the root directory (next to the package.json)
I run building via Huge thanks @sebastiannm for the note. |
Hi @anufriev, that didn't worked perfectly. But changing to this works:
|
oh man, so sad to hear, I loved the gzip feature 😞 |
You should guys leave it as special option with additional flag. |
@anufriev, did you have to modify the index.html file or the lazy load? I tried your suggestion and I was not able to get it to work. |
@filipesilva I wasn't able to find any documentation on the new plugin architecture for angular-cli. Is it still in development and if so will it be released soon? So far using |
So, what is the "easy workaround" then? #4618 (comment) talks about it but does not explain it ... |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Followup from #4618
BREAKING CHANGE: compressed code (
.gz
) is no longer generated on production builds.