-
Notifications
You must be signed in to change notification settings - Fork 12k
feat(@angular/cli): add an eject command #4680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a7aa412
chore: fix typings for Jasmine and TS 2.0
hansl 3427cdc
refactor: removed unused import
hansl 2420b0b
fix(@angular/cli): lint now works with excluded files.
hansl 5d3c5dc
feat(@ngtools/webpack): add an option to redirect files
hansl d3f9dfd
test: e2e exec() now returns an object {stdout,stderr}
hansl bb891df
feat(@angular/cli): eject command
hansl 8f2b1ce
feat(@angular/cli): version shows ejected app or not
hansl 596f35d
feat(@angular/cli): disable invalid commands on ejected apps
hansl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
import { BuildOptions } from '../models/build-options'; | ||
import { Version } from '../upgrade/version'; | ||
import {baseBuildCommandOptions} from './build'; | ||
|
||
const Command = require('../ember-cli/lib/models/command'); | ||
|
||
// defaults for BuildOptions | ||
export const baseEjectCommandOptions: any = [ | ||
...baseBuildCommandOptions, | ||
{ name: 'force', 'type': Boolean } | ||
]; | ||
|
||
export interface EjectTaskOptions extends BuildOptions { | ||
force?: boolean; | ||
} | ||
|
||
|
||
const EjectCommand = Command.extend({ | ||
name: 'eject', | ||
description: 'Ejects your app and output the proper webpack configuration and scripts.', | ||
|
||
availableOptions: baseEjectCommandOptions, | ||
|
||
run: function (commandOptions: EjectTaskOptions) { | ||
const project = this.project; | ||
const EjectTask = require('../tasks/eject').default; | ||
const ejectTask = new EjectTask({ | ||
cliProject: project, | ||
ui: this.ui, | ||
}); | ||
|
||
return ejectTask.run(commandOptions); | ||
} | ||
}); | ||
|
||
|
||
export default EjectCommand; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,11 @@ | |
}, | ||
"name": { | ||
"type": "string" | ||
}, | ||
"ejected": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add a description There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch. Done. |
||
"description": "Whether or not this project was ejected.", | ||
"type": "boolean", | ||
"default": false | ||
} | ||
}, | ||
"additionalProperties": false | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
// Exports the webpack plugins we use internally. | ||
|
||
module.exports = { | ||
BaseHrefWebpackPlugin: | ||
require('../lib/base-href-webpack/base-href-webpack-plugin').BaseHrefWebpackPlugin, | ||
GlobCopyWebpackPlugin: require('../plugins/glob-copy-webpack-plugin').GlobCopyWebpackPlugin, | ||
SuppressExtractedTextChunksWebpackPlugin: | ||
require('../plugins/suppress-entry-chunks-webpack-plugin') | ||
.SuppressExtractedTextChunksWebpackPlugin | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be referenced from
baseBuildCommandOptions
incommands/build.ts
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.