Skip to content

build(@angular/cli): fix @angular dep warnings #4592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2017

Conversation

filipesilva
Copy link
Contributor

We still need these dependencies as they are peerDeps of @ngtools/webpack.

Partially revert #4473
Fix #4575

@filipesilva filipesilva requested review from hansl and Brocco February 10, 2017 11:34
@filipesilva filipesilva force-pushed the fix-deps-warnings branch 2 times, most recently from 42cadda to 391d129 Compare February 10, 2017 21:27
"@angular/compiler": ">=2.3.1 <5.0.0",
"@angular/compiler-cli": ">=2.3.1 <5.0.0",
"@angular/core": ">=2.3.1 <5.0.0",
"@angular/tsc-wrapped": "^0.5.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Angular 4, tac-wrapped has moved to using the same version.

npm show @angular/tsc-wrapped versions

[ '0.1.0',
  '0.2.0',
  '0.2.1',
  '0.2.2',
  '0.3.0',
  '0.4.0',
  '0.4.1',
  '0.4.2',
  '0.5.0',
  '0.5.1',
  '0.5.2',
  '4.0.0-beta.2',
  '4.0.0-beta.4',
  '4.0.0-beta.5',
  '4.0.0-beta.6',
  '4.0.0-beta.7' ]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

We still need these dependencies as they are peerDeps of @ngtools/webpack.

Partially revert angular#4473
Fix angular#4575
Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but tests are failing. I think just a rebase would pass the tests.

@filipesilva filipesilva merged commit e0aa986 into angular:master Feb 15, 2017
@filipesilva filipesilva deleted the fix-deps-warnings branch February 15, 2017 20:02
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
We still need these dependencies as they are peerDeps of @ngtools/webpack.

Partially revert angular#4473
Fix angular#4575
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[beta.31] npm WARN at installation in global
4 participants