Skip to content

test: add license test #4561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 17, 2017
Merged

Conversation

filipesilva
Copy link
Contributor

@filipesilva filipesilva commented Feb 9, 2017

Partially address #3884

Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll check those out in the same PR before merging. Thanks!

@filipesilva
Copy link
Contributor Author

@hansl should be finished now.

@filipesilva filipesilva force-pushed the third-party-licensing branch from 916bcc1 to 11e9ec7 Compare February 17, 2017 11:20
@filipesilva filipesilva force-pushed the third-party-licensing branch from 11e9ec7 to b9bb695 Compare February 17, 2017 11:39
@filipesilva
Copy link
Contributor Author

@hansl rebased and passing tests.

@filipesilva filipesilva merged commit 6d5dfa0 into angular:master Feb 17, 2017
@filipesilva filipesilva deleted the third-party-licensing branch February 17, 2017 14:49
@filipesilva filipesilva mentioned this pull request Feb 17, 2017
4 tasks
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
* test: add license test

* only check prod dependencies

* remove findup dep

* also check dev deps

* add map-stream to ignore list

* remove license-checker

* add comment

* use logger

* fix lint errors
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants