Skip to content

support source mapping for component styles. add html-loader. #4491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

asnowwolf
Copy link

feat add css-with-mapping-loader to enable source mapping for component style
feat: add html-loader
feat: inline small SVG files referenced by HTML/CSS as dataURLs

NOTICE: Currently, angular will lost source mapping of component style, see my another PR: angular/angular#14175 . To experiment, please manually patch it first.

…ent style

feat: add html-loader
feat: inline small SVG files referenced by HTML/CSS as dataURLs
@asnowwolf asnowwolf force-pushed the html-loader-and-embed-svg branch from 7aa8dd9 to e995e8b Compare February 7, 2017 14:53
@hansl
Copy link
Contributor

hansl commented Feb 7, 2017

This PR does not seem to have a focused fix or feature, fails all the tests in the list, and does not have an issue attached to it. I'm going to close this.

@hansl hansl closed this Feb 7, 2017
@asnowwolf
Copy link
Author

asnowwolf commented Feb 8, 2017

The problems it solves are:

  1. For the Component Styles file, you can not see the correct SourceMap information when debugging.
  2. When packing all the image files are not given the correct "cache-busting hash"

Should I first commit the issues before submit PR?

@asnowwolf
Copy link
Author

asnowwolf commented Feb 8, 2017

And also, a test fail is because:

error An unexpected error occurred: "https://registry.yarnpkg.com/requires-port/-/requires-port-1.0.0.tgz: Request failed "502 Bad Gateway"".

But I will remove all node_modules and re-run npm test on my mac.

@asnowwolf
Copy link
Author

asnowwolf commented Feb 8, 2017

All unit testing is green, but finally, It's failed because:

2 excessive dependencies in package.json:
    css-with-mapping-loader
    html-loader

Does we don't allow to add new dependencies? or need approval first?

@asnowwolf
Copy link
Author

e2e testing is ok now.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants