Skip to content

chore: update all tsconfig libs to enable es2016 apis #4458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2017

Conversation

delasteve
Copy link
Contributor

No description provided.

@delasteve delasteve force-pushed the chore/update-ts-libs branch 2 times, most recently from b229ec5 to 7bdb8ff Compare February 6, 2017 15:52
@filipesilva filipesilva requested a review from hansl February 6, 2017 16:01
@hansl
Copy link
Contributor

hansl commented Feb 6, 2017

Could you explain in better details why we need this change? Just "update tsconfig" isn't enough for context :)

@delasteve delasteve force-pushed the chore/update-ts-libs branch from 7bdb8ff to e81abe6 Compare February 6, 2017 23:40
@delasteve delasteve changed the title chore: update tsconfigs included libraries chore: update all tsconfig libs to enable es2016 apis Feb 6, 2017
Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hansl hansl merged commit 63151d5 into angular:master Feb 7, 2017
@@ -4,9 +4,12 @@
"declaration": false,
"emitDecoratorMetadata": true,
"experimentalDecorators": true,
"lib": ["es6", "dom"],
"lib": [
"es2015",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@delasteve should it be "es2015" here (lib and module properties) when all other files are "es2016"?

hansl pushed a commit to hansl/angular-cli that referenced this pull request Feb 7, 2017
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
@delasteve delasteve deleted the chore/update-ts-libs branch February 22, 2017 20:12
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants