fix(generate): ignore duplicate component symbol in module declarations #4446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delasteve
force-pushed
the
fix/double-declaration
branch
4 times, most recently
from
72af96b to
2484124
Compare
hansl
suggested changes
Feb 7, 2017
| return new NoopChange(); | ||
| } | ||
| } | ||
|
|
| @@ -254,7 +262,7 @@ function _addSymbolToNgModuleMetadata(ngModulePath: string, metadataField: strin | |||
| * into NgModule declarations. It also imports the component. | |||
| */ | |||
| export function addDeclarationToModule(modulePath: string, classifiedName: string, | |||
| importPath: string): Promise<Change> { | |||
| importPath: string): Promise<Change> { | |||
| @@ -54,13 +54,13 @@ export default Blueprint.extend({ | |||
|
|
|||
| let defaultPrefix = ''; | |||
| if (this.project.ngConfig && | |||
| this.project.ngConfig.apps[0] && | |||
| this.project.ngConfig.apps[0].prefix) { | |||
| this.project.ngConfig.apps[0] && | |||
There was a problem hiding this comment.
Revert these whitespace changes.
delasteve
force-pushed
the
fix/double-declaration
branch
4 times, most recently
from
7e393c1 to
c3df47f
Compare
|
@hansl fixed :) |
delasteve
force-pushed
the
fix/double-declaration
branch
from
c3df47f to
4d491ec
Compare
"ng g c X" will no longer insert the component symbol in the NgModule's declaration array should it already exist. Closes angular#4323
delasteve
force-pushed
the
fix/double-declaration
branch
from
4d491ec to
25ca13a
Compare
|
Seems like the changes @hansl asked for were made so marking for merge. |
filipesilva
approved these changes
Feb 14, 2017
hansl
approved these changes
Feb 17, 2017
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
…ymbol (angular#4446) "ng g c X" will no longer insert the component symbol in the NgModule's declaration array should it already exist. Closes angular#4323
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ng g c Xwill no longer insert the component symbol in the NgModule's declaration array should it already exist.Closes #4323
// cc @beeman, @Meligy