Skip to content

style(@angular/cli): fix INITIAL_COMMIT_MESSAGE #4423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2017

Conversation

scmx
Copy link
Contributor

@scmx scmx commented Feb 3, 2017

Git commit messages should always have a blank line after the title.

Git commit messages should always have a blank line after the title.
@hansl
Copy link
Contributor

hansl commented Feb 3, 2017

LGTM, thanks!

@hansl hansl merged commit 375130f into angular:master Feb 3, 2017
@scmx
Copy link
Contributor Author

scmx commented Feb 3, 2017

Otherwise git branch -v will act very strange

$ git branch -v
master 08edefe chore: initial commit from angular-cli _ _ _ __ _ _ __ __ _ _ | | __ _ _ __ | () / _ | _ \ / _ | | | | |/ _ | | / __| | | | (| | | | | (| | || | | (| | | || (| | | _|| ||_ |_||_|| _||| |_/

My editor wanted me to add a newline at the end of file and remove trailing whitespace as well

@scmx
Copy link
Contributor Author

scmx commented Feb 3, 2017

@hansl wow, that was fast 🚀 🚤

@scmx scmx deleted the fix-blank-line-initial-commit-message branch February 3, 2017 21:37
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants